Make with_info_handler take rest args to fix upstream arity change
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream `with_info_handler` method was changed to take an extra parameter, which is now breaking the implementation of the method in this gem. This commit fixes the issue by making the method take rest arguments, which will allow it to work with the upstream changes, and any other positional arguments that might be added in the future.
|
Thanks for the patch! I'll test and merge shortly, and release a new version after. |
|
minitest-hooks 1.5.2 has been released with this fix. Thank you very much! |
flavorjones
added a commit
to flavorjones/mini_portile
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
The upstream
with_info_handlermethod was changed to take an extra parameter, which is now breaking the implementation of the method in this gem. This commit fixes the issue by making the method take rest arguments, which will allow it to work with the upstream changes, and any other positional arguments that might be added in the future.