Skip to content

Commit

Permalink
CI: fix dll dependency check
Browse files Browse the repository at this point in the history
The find expression was broken for a couple of reasons: it does not run in a subshell (so cannot use && like that), and it needs split arguments not one quoted argument.  Avoid having to call echo by using -printf argument.

Fixes msys2#4611
  • Loading branch information
jeremyd2019 authored May 22, 2024
1 parent b18becd commit 8c2520b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .ci/ci-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ install_packages() {
list_dll_deps(){
local target="${1}"
echo "$(tput setaf 2)MSYS2 DLL dependencies:$(tput sgr0)"
find "$target" -regex ".*\.\(exe\|dll\)" -exec "echo '{}:' && ldd '{}';" | GREP_COLOR="1;35" grep --color=always "msys-.*\|" \
find "$target" -regex ".*\.\(exe\|dll\)" -printf '%p:\n' -exec ldd '{}' \; | GREP_COLOR="1;35" grep --color=always "msys-.*\|" \
|| echo " None"
}

Expand Down

0 comments on commit 8c2520b

Please sign in to comment.