Skip to content

Commit

Permalink
fix(pwa): use compatible service worker name
Browse files Browse the repository at this point in the history
This restores backwards compatibility with create-react-app-based builds
  • Loading branch information
jeremyckahn committed Mar 13, 2024
1 parent 520b863 commit 7c5c121
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@ jobs:
run: |
npm ci
npm run build
# NOTE: This is a compatibility shim needed for upgrading installed
# Chitchatter PWAs after the switch to Vite:
# https://github.com/jeremyckahn/chitchatter/commit/ea34058fa7ac2cbfd165837cdbef5caf6a9645ce#diff-639916bc14c3f311c31f629a2ec116292a4b2f64d06b3607b9ddd2e495703895
#
# TODO: Remove this cp operation after 9/1/2023.
cp dist/manifest.webmanifest dist/manifest.json
- name: Deploy
uses: peaceiris/actions-gh-pages@v3
Expand Down
1 change: 1 addition & 0 deletions vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const config = () => {
enabled: false,
},
injectRegister: 'auto',
filename: 'service-worker.js',
manifest,
}),
],
Expand Down

0 comments on commit 7c5c121

Please sign in to comment.