Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/forwardingoptions_dhcprelay_servergroup: ip_address argument is no longer ordered #749

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<!-- markdownlint-disable-file MD013 MD041 -->
ENHANCEMENTS:

* **resource/junos_forwardingoptions_dhcprelay_servergroup**: `ip_address` argument is no longer ordered
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ The following arguments are supported:
- **version** (Optional, String, Forces new resource)
Version for DHCP or DHCPv6.
Need to be `v4` or `v6`.
- **ip_address** (Optional, List of String)
- **ip_address** (Optional, Set of String)
IP Addresses of DHCP servers.

## Attribute Reference
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"github.com/jeremmfr/terraform-provider-junos/internal/tfdiag"
"github.com/jeremmfr/terraform-provider-junos/internal/tfvalidator"

"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
"github.com/hashicorp/terraform-plugin-framework-validators/setvalidator"
"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
"github.com/hashicorp/terraform-plugin-framework/path"
"github.com/hashicorp/terraform-plugin-framework/resource"
Expand Down Expand Up @@ -120,14 +120,14 @@ func (rsc *forwardingoptionsDhcprelayServergroup) Schema(
stringvalidator.OneOf("v4", "v6"),
},
},
"ip_address": schema.ListAttribute{
"ip_address": schema.SetAttribute{
ElementType: types.StringType,
Optional: true,
Description: "IP Addresses of DHCP servers.",
Validators: []validator.List{
listvalidator.SizeAtLeast(1),
listvalidator.NoNullValues(),
listvalidator.ValueStringsAre(
Validators: []validator.Set{
setvalidator.SizeAtLeast(1),
setvalidator.NoNullValues(),
setvalidator.ValueStringsAre(
tfvalidator.StringIPAddress(),
),
},
Expand Down
Loading