Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface esi settings #134

Merged
merged 22 commits into from
Mar 5, 2021
Merged

Add interface esi settings #134

merged 22 commits into from
Mar 5, 2021

Conversation

dejongm
Copy link
Contributor

@dejongm dejongm commented Feb 18, 2021

Implements enhancement #126

jeremmfr
jeremmfr requested changes Feb 19, 2021
View reviewed changes
Copy link
Owner

@jeremmfr jeremmfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several corrections to be made.
I don't have review testacc file yet

junos/func_common.go Outdated Show resolved Hide resolved
junos/func_resource_interface_physical.go Outdated Show resolved Hide resolved
junos/func_resource_interface_physical.go Outdated Show resolved Hide resolved
junos/func_resource_interface_physical.go Outdated Show resolved Hide resolved
junos/func_resource_interface_physical.go Outdated Show resolved Hide resolved
website/docs/r/interface_physical.html.markdown Outdated Show resolved Hide resolved
website/docs/r/interface_physical.html.markdown Outdated Show resolved Hide resolved
website/docs/r/interface_physical.html.markdown Outdated Show resolved Hide resolved
website/docs/r/interface_physical.html.markdown Outdated Show resolved Hide resolved
website/docs/r/interface_physical.html.markdown Outdated Show resolved Hide resolved
@dejongm
Copy link
Contributor Author

dejongm commented Feb 23, 2021

@jeremmfr, Thanks for your previous feedback! This PR is ready for review.

jeremmfr
jeremmfr requested changes Feb 26, 2021
View reviewed changes
Copy link
Owner

@jeremmfr jeremmfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor errors need to be fixed and file junos/.resource_bgp_group.go.swp must be git remove.

junos/resource_interface_physical.go Outdated Show resolved Hide resolved
website/docs/r/interface_physical.html.markdown Outdated Show resolved Hide resolved
website/docs/r/interface_physical.html.markdown Outdated Show resolved Hide resolved
website/docs/r/interface_physical.html.markdown Outdated Show resolved Hide resolved
junos/resource_interface_physical_test.go Outdated Show resolved Hide resolved
junos/resource_interface_physical_test.go Outdated Show resolved Hide resolved
@jeremmfr jeremmfr linked an issue Feb 26, 2021 that may be closed by this pull request
Add ESI Settings to Interface config #126
Closed
@jeremmfr jeremmfr self-assigned this Feb 26, 2021
@dejongm dejongm requested a review from jeremmfr March 4, 2021 16:03
jeremmfr
jeremmfr requested changes Mar 4, 2021
View reviewed changes
Copy link
Owner

@jeremmfr jeremmfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove ~/.terraform.d/plugins/registry.local/jeremmfr/junos/1.12.3/linux_amd64/terraform-provider-junos_1.12.3 binary file that you pushed in last commit ?

@dejongm dejongm requested a review from jeremmfr March 4, 2021 17:55
@jeremmfr jeremmfr merged commit 3df783e into jeremmfr:master Mar 5, 2021
@jeremmfr jeremmfr added this to the v1.14.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremmfr jeremmfr jeremmfr approved these changes

Assignees

@jeremmfr jeremmfr

Labels
None yet
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

Add ESI Settings to Interface config
3 participants
@dejongm @jeremmfr @markdejong-nreca