Merge pull request #592 from jeremmfr/bugfix-2.3.2

Release v2.3.3
jeremmfr · Dec 7, 2023 · 25b0795 · 25b0795
2 parents 41b6233 + a373f3e
commit 25b0795
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,12 @@
 <!-- markdownlint-disable-file MD013 MD041 -->
 # changelog
 
+## v2.3.3 (December 07, 2023)
+
+BUG FIXES:
+
+* **resource/junos_system**: fix crash when `web_management_https` is defined and `web_management_http` is not (Fix [#588](https://github.com/jeremmfr/terraform-provider-junos/issues/588))
+
 ## v2.3.2 (November 16, 2023)
 
 BUG FIXES:

diff --git a/internal/providerfwk/resource_system.go b/internal/providerfwk/resource_system.go
@@ -3573,7 +3573,7 @@ func (block *systemBlockServices) configSet() (
 			configSet = append(configSet,
 				setPrefix+"web-management https pki-local-certificate \""+v+"\"")
 		}
-		if !block.WebManagementHTTP.Port.IsNull() {
+		if !block.WebManagementHTTPS.Port.IsNull() {
 			configSet = append(configSet, setPrefix+"web-management https port "+
 				utils.ConvI64toa(block.WebManagementHTTPS.Port.ValueInt64()))
 		}