Skip to content

Commit

Permalink
Encode external fizz runtime into chunks eagerly (facebook#26752)
Browse files Browse the repository at this point in the history
Summary:
in facebook/react#26738 we added nonce to the
ResponseState. Initially it was used in a variety of places but the
version that got merged only included it with the external fizz runtime.
This PR updates the config for the external fizz runtime so that the
nonce is encoded into the script chunks at request creation time.

The rationale is that for live-requests, streaming is more likely than
not so doing the encoding work at the start is better than during flush.
For cases such as SSG where the runtime is not required the extra
encoding is tolerable (not a live request). Bots are an interesting case
because if you want fastest TTFB you will end up requiring the runtime
but if you are withholding until the stream is done you have already
sacrificed fastest TTFB and the marginal slowdown of the extraneous
encoding is hopefully neglibible

I'm writing this so later if we learn that this tradeoff isn't worth it
we at least understand why I made the change in the first place.

DiffTrain build for commit facebook/react@8ea96ef.

Changelog: [Internal]

<< DO NOT EDIT BELOW THIS LINE >>

Reviewed By: sammy-SC

Differential Revision: D45449587

Pulled By: tyao1

fbshipit-source-id: 76a5f34e42db5e9ad5a78b4b8f0d4e3dad2e7fcd
  • Loading branch information
gnoff authored and jeongshin committed May 7, 2023
1 parent 615b35e commit 26e63b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Renderer/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
491aec5d6113ce5bae7c10966bc38a4a8fc091a8
8ea96ef84d8f08ed1846dec9e8ed20d2225db0d3

0 comments on commit 26e63b1

Please sign in to comment.