[Fix] Update dependent active record #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lti-databases Fix schema:dump monkey patched task to handle multiple database config
|
Thanks @sandeep-patle1508! Sorry I missed this one until now 😢 ... are you still interested in moving this forward? If so, take a look at the conflicts and I'll be happy to review it once they're resolved |
Hi @jenseng Please review and add your comments if any changes are required. |
|
Closing in favor of #110 |
jenseng
pushed a commit
that referenced
this pull request
Jan 2, 2024
) Fix following issue(#95). This is the rebase from pull request #98. **Background:** We are trying to set up multiple databases with our **Rails 7** application. Due to this gem, we are facing an issue. When we are running **rails db:migrate** it is overwriting the primary **db/schema.rb** file with secondary schema file **db/marketing_sync_board_schema.rb**. After the migration command run both are the same. They are not causing any database label changes. Also if we are using database-specific command it is working fine. `rails db:migrate` `rails db:migrate:marketing_sync_board` sample database.yml with multi database setup. <pre> default: &default adapter: postgresql encoding: unicode host: localhost database: multi_db_test_app_development username: admin password: pool: <%= ENV.fetch('RAILS_MAX_THREADS') { 5 } %> marketing_sync_board_default: &marketing_sync_board_default <<: *default host: localhost username: admin password: database: marketing_sync_board_development migrations_paths: db/marketing_sync_board_migrate development: primary: <<: *default database: multi_db_test_app_secondary_development marketing_sync_board: <<: *marketing_sync_board_default </pre>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependent active record to min 6.0.0 to support multi-database setup.