Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two items to meeting and one item to conference #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lex-files
Copy link

No description provided.

@AmeliaMN
Copy link
Contributor

LGTM, although I wonder if there will be conflicts after #42 and #43 are merged.

@jennybc
Copy link
Owner

jennybc commented Apr 14, 2019

Yep, merge conflict. See #42 for a review of ways we can proceed.

@AmeliaMN
Copy link
Contributor

Hey @lex-files, this conflict isn't your fault (it's because multiple people were editing the same file), but because your PR is being merged later, it cropped up. If you're looking at this conversation on GitHub you should be able to resolve the conflict right here, and I'm happy to talk through it with you in person later today if you'd like! Let me know.

Copy link
Owner

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A closing " needs to be restored to one of the entries. Note that this also is flagged via the automated tests, which is a handy thing.

inst/topics/boring-meeting.R Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants