update bom to pickup fixed subversion for tests #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
commented
Jun 14, 2024
| <no-test-jar>false</no-test-jar> | ||
| <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> | ||
| </properties> | ||
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.jenkins.tools.bom</groupId> | ||
| <artifactId>bom-2.440.x</artifactId> | ||
| <version>2746.vb_79a_1d3e7b_c8</version> | ||
| <artifactId>bom-2.452.x</artifactId> |
There was a problem hiding this comment.
use bom corresponding to LTS line
| <artifactId>bom-2.440.x</artifactId> | ||
| <version>2746.vb_79a_1d3e7b_c8</version> | ||
| <artifactId>bom-2.452.x</artifactId> | ||
| <version>3010.vec758b_8e7da_3</version> |
There was a problem hiding this comment.
not the latest version but has the required cloudbees-folder update
jtnord
changed the title
|
based on #309 (comment) I think the updated bom is all that is needed for the backport (so we get the fixed subversion plugin when not running against a bom that contains subversion). |
jglick
reviewed
Jun 14, 2024
jtnord
changed the title
when running tests with PCT issues with subversion are found as it can not resolve trilead classes. update the bom to pickup https://github.com/jenkinsci/subversion-plugin/releases/tag/1256.vee91953217b_6
jglick
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
align to LTS and pickup bom with fixed subversion
when running tests with PCT and a newer git-client issues with subversion are found as it can not resolve trilead classes.
the version of subversion-plugin used but did not declare a dependency on trilead, so this fixes the issue by update the bom to pickup https://github.com/jenkinsci/subversion-plugin/releases/tag/1256.vee91953217b_6
@jglick @olamy
Testing done
Submitter checklist