Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-61654: allow customization of used SCMRevision #157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dev-hanz-ops
Copy link

@dev-hanz-ops dev-hanz-ops commented Jan 25, 2022

This PR addresses JENKINS-61654 and is an improved version of #155

The original PR was created to make this plugin use the revision of an upstream job, if a build was triggered using the build step.

Contrary to #155, this one is more flexible:

  • The determination of the SCMRevision is not hardcoded in this plugin, so that it can be used for more than just upstream/downstream builds
  • Plugins can create such behavior/trait for any SCMSource (not only GitHub)
  • Behavior can be turned on & off by the user

Also, no additional pom dependency is required, as everything is handled in newly-created plugins. One example for such a plugin is the (not yet published) github-upstream-revision-plugin

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant