Persist ReplayFlowFactoryAction#sandbox
#968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CBCI HA scenarios, the Queue.Item (and its actions) can be rescheduled in another Jenkins replica. In such case it is required to persist the `sandbox` field, otherwise the reschedule will run without sandbox.
Vlatombe
changed the title
ReplayFlowFactoryAction#sandbox
Vlatombe
commented
Jan 6, 2025
| @@ -52,7 +52,7 @@ class ReplayFlowFactoryAction extends InvisibleAction implements CpsFlowFactoryA | |||
|
|
|||
| private String replacementMainScript; | |||
| private final Map<String,String> replacementLoadedScripts; | |||
| private transient final boolean sandbox; | |||
| private final boolean sandbox; | |||
There was a problem hiding this comment.
Could avoid persisting it in build.xml as well, though unlike replacementMainScript the size impact is negligible.
jglick
reviewed
Jan 6, 2025
plugin/src/test/java/org/jenkinsci/plugins/workflow/Workflow2Test.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Jan 6, 2025
plugin/src/test/java/org/jenkinsci/plugins/workflow/Workflow2Test.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
Jan 6, 2025
jglick
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CBCI HA scenarios, the
Queue.Item(and its actions) can be rescheduled in another Jenkins replica. In such case it is required to persist thesandboxfield, otherwise the reschedule will run without sandbox.In a regular OSS Jenkins, you can hit the problem is you disable concurrent build execution and arrange for a build to be queued, then restart the controller, as demonstrated in the provided test.
Testing done
Tested in CBCI HA context.
Submitter checklist