Forward compatibility with Guice 7 #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Jan 16, 2024
| @@ -1,7 +1,7 @@ | |||
| package org.jenkinsci.plugins.workflow.cps.steps; | |||
|
|
|||
| import edu.umd.cs.findbugs.annotations.CheckForNull; | |||
| import javax.inject.Inject; | |||
| import jakarta.inject.Inject; | |||
There was a problem hiding this comment.
FYI
Jenkins.get or JenkinsRule.jenkins.
There was a problem hiding this comment.
Agreed that the existing code is gratuitous. The intended scope of this set of PRs was to do a simple bulk package rename rather than a deep code cleanup of existing code.
jglick
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without dropping compatibility with Guice 6 (currently delivered by Jenkins core), add support for Guice 7.