[JENKINS-70591] Cannot create inline Pipeline job after Ace editor upgrade #657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#653 (comment) was an assertion without evidence, and also an incorrect one — the cause of JENKINS-70591 was #656, not #653. This was determined after a few minutes of bisection. Using the JQuery
ready()
API gets rid of this bug and is consistent with the code elsewhere in this file which uses JQuery rather than plain JavaScript. Note that I followed the recommended syntax:The
$(function() {
syntax did look odd to me, but it is explicitly recommended in the documentation:To test this, I reproduced the problem described in JENKINS-70591 and verified the problem no longer occurred after this PR. I also repeated the testing done in #656 and #653.