[JENKINS-68071] Java 17 compat: make CpsThreadGroup.paused transient to avoid XStreaming AtomicBoolean
#515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reaming `AtomicBoolean`
basil
approved these changes
Mar 18, 2022
| /** | ||
| * Persistent version of {@link #paused}. | ||
| */ | ||
| private boolean executionPaused; |
There was a problem hiding this comment.
Might not hurt to make this volatile? No strong preference.
There was a problem hiding this comment.
Or maybe make it Boolean and only set it to a non-null value in writeReplace (and null it out in readResolve).
There was a problem hiding this comment.
No need for volatile since it is not read except during deserialization.
Considered setting it during writeReplace but seemed like overkill since it is only ever written in two places and it just as easy to set it then.
dwnusbaum
approved these changes
Mar 18, 2022
| /** | ||
| * Persistent version of {@link #paused}. | ||
| */ | ||
| private boolean executionPaused; |
There was a problem hiding this comment.
Or maybe make it Boolean and only set it to a non-null value in writeReplace (and null it out in readResolve).
car-roll
approved these changes
Mar 18, 2022
jglick
changed the title
CpsThreadGroup.paused transient to avoid XStreaming AtomicBooleanCpsThreadGroup.paused transient to avoid XStreaming AtomicBoolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-68071
Amends #32. Relevant test coverage is in
CpsFlowExecutionTest. Fixes the Java 17 run ofprinting as expected