-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test of serial form of program.dat
including pickles
#489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be interesting to add another test where program.dat
exists but is corrupted, but the new test looks fine to me.
@@ -0,0 +1,50 @@ | |||
<?xml version='1.1' encoding='UTF-8'?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Personally I prefer to use ZIP files with @LocalData
so this kind of stuff does not come up in GitHub searches, but maybe you prefer doing things this way for other reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
come up in GitHub searches
Could be an issue I suppose. I normally prefer exploded $JENKINS_HOME
because it is easier to review, and occasionally it even makes sense to change one line of one file, which in a ZIP would just be an opaque blob.
Could be interesting for certain purposes. The motivation here was unrelated—to verify that the existing format of current Pipeline builds using common steps can still be loaded even if we move the JBoss Marshalling code here from |
Downstream of jenkinsci/jenkins-test-harness#352.
Motivation: jenkinsci/workflow-support-plugin#126 (comment)
strings on saved program.dat