Adjust GlobalLibraries#configRoundTrip test for latest LTS #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
changed the title
jglick
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Yeah I think so. When jenkins.version is updated we could also do some rework to support jenkinsci/jenkins#4501 better. Note there is also an open RFE to allow an admin to configure an untrusted global lib, which would be a natural thing to offer to someone with only Overall/Manage.
jtnord
approved these changes
Apr 13, 2020
dwnusbaum
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails on the latest LTS (2.222.1) picked up in jenkinsci/bom#214
Most likely due to: jenkinsci/jenkins#4365
The test case appears to be invalid now so have removed the RUN_SCRIPTS testing
cc @dwnusbaum @bitwiseman @jglick