[JENKINS-33358] Test against 2.73.x since that includes Groovy 2.4.11 #41
Conversation
Jenkinsfile
Outdated
| @@ -1 +1 @@ | |||
| buildPlugin(jenkinsVersions: [null, '2.32.3', '2.47']) | |||
| buildPlugin(jenkinsVersions: [null, '2.32.3', '2.60.3', '2.73.1']) | |||
There was a problem hiding this comment.
Probably you want to bump up the jenkins.version to 2.7.3, in which case we could drop the tests against 2.32.x I think.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
… security advisory and its immediate regression fixes.
| @@ -1 +1 @@ | |||
| buildPlugin(jenkinsVersions: [null, '2.32.3', '2.47']) | |||
| buildPlugin(jenkinsVersions: [null, '2.60.3', '2.73.1']) | |||
There was a problem hiding this comment.
2.7.x–2.47 uses one version of Groovy, 2.48–2.60.x another, 2.61+ yet another. At least we are dropping 1.x!
| <jenkins.version>1.642.3</jenkins.version> | ||
| <workflow-cps-plugin.version>2.30</workflow-cps-plugin.version> | ||
| <jenkins.version>2.7.3</jenkins.version> | ||
| <workflow-cps-plugin.version>2.39</workflow-cps-plugin.version> |
| @@ -108,7 +108,7 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>script-security</artifactId> | |||
| <version>1.27</version> | |||
| <version>1.33</version> | |||
There was a problem hiding this comment.
ditto, plus some follow-up fixes likely to affect testing of Groovy-heavy code like this
There was a problem hiding this comment.
We could theoretically go straight to 1.34, but 1.33 is good enough, yeah.
| @@ -93,7 +93,6 @@ | |||
|
|
|||
| // TODO test transitive dependencies; need to find something in Central which has a dependency not in this plugin’s test classpath and which could be used easily from a script | |||
|
|
|||
| @Ignore("TODO ClassNodeResolver.tryAsLoaderClassOrScript swallows the CompilationFailedException and throws a generic GroovyBugError; fixed in Jenkins 2 / Groovy 2") | |||
There was a problem hiding this comment.
Can finally have automated tests cover Jenkins 2 behaviors.
| @@ -108,7 +108,7 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>script-security</artifactId> | |||
| <version>1.27</version> | |||
| <version>1.33</version> | |||
There was a problem hiding this comment.
We could theoretically go straight to 1.34, but 1.33 is good enough, yeah.
|
Webhooks broken pending hub4j/github-api#373, will try to retrigger. |
|
@reviewbybees done |
Like jenkinsci/workflow-cps-plugin#175.
@reviewbybees