Use standard Jenkins POM in Winstone, Refactor the project structure #46
Conversation
This change introduces Jenkins parent POM 1.37 in the project and restructures it to be compatible with default project layout in the organization.
| @@ -1,6 +1,8 @@ | |||
| package winstone; | |||
|
|
|||
| import junit.framework.TestCase; | |||
| import winstone.BoundedExecutorService; | |||
| import winstone.Launcher; | |||
There was a problem hiding this comment.
The packages haven't changed, right, so why are these necessary? I guess Launcher could be hudson.Launcher, but I'm not sure about BoundedExecutorService.
There was a problem hiding this comment.
Likely it was a refactoring mess, will fix
| @@ -27,6 +28,7 @@ | |||
| * @author <a href="mailto:[email protected]">Rick Knowles</a> | |||
| * @version $Id: LoadTest.java,v 1.2 2006/02/28 07:32:49 rickknowles Exp $ | |||
| */ | |||
| @Ignore | |||
There was a problem hiding this comment.
Maybe specify the reason: @Ignore("Intended to be run manually"). (At least I think that is why it was excluded previously.)
|
Since it's not urgent, I will try to integrate a new parent POM with FindBugs support. |
|
Hi @oleg-nenashev |
|
@olamy will do within few hours |
|
comments have been addressed |
| @@ -1,5 +1,5 @@ | |||
| LoadTest.Usage=Winstone Command Line Load Tester\n\ | |||
| Usage: java winstone.testCase.load.LoadTest --url=<url> \ | |||
oleg-nenashev
changed the title
|
@olamy done, I hope it unblocks you |
|
@olamy should I cut the release or wait for your patch to arrive? |
During the release of 4.1.1 I hit the issue with source uploads, which was failing the release due to the duplication of artifacts. So I decided to fix it and to align pom.xml with other Jenkins components.
This change introduces Jenkins parent POM 1.37 in the project and restructures it to be compatible with default project layout in the organization.
@reviewbybees @olamy