Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72059] Add new quality gate options to alter the stage only #1649

Merged
merged 17 commits into from
Feb 23, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Dec 29, 2023

Downstream PR of jenkinsci/plugin-util-api-plugin#309.

Add support for setting the stage result without touching the overall build result.

Bildschirmfoto 2024-01-08 um 09 06 58

@uhafner uhafner added the enhancement Enhancement of existing functionality label Dec 29, 2023
import static org.mockito.Mockito.*;

/**
* Tests the class {@link QualityGate}.
*
* @author Ullrich Hafner
*/
class QualityGateTest extends SerializableTest<QualityGate> {
class QualityGateTest extends SerializableTest<WarningsQualityGate> {

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note test

Unused class: QualityGateTest is not referenced within this codebase. If not used as an external API it should be removed.
@laeubi
Copy link

laeubi commented Jan 17, 2024

@uhafner this would be a very useful option and I was actually looking for this, we are using the Git integration and it shows the whole build failed even if just one Quality Gate is failing.

Even worse it is reported as a TEST-FAILURE if one uses the mark unstable option:

grafik

with the default the build is just marked as completely failed and it is very hard to find in the log WHY ... so this new option seems a good alternative here!

@uhafner
Copy link
Member Author

uhafner commented Jan 17, 2024

@uhafner this would be a very useful option and I was actually looking for this, we are using the Git integration and it shows the whole build failed even if just one Quality Gate is failing.

Even worse it is reported as a TEST-FAILURE if one uses the mark unstable option:

grafik

with the default the build is just marked as completely failed and it is very hard to find in the log WHY ... so this new option seems a good alternative here!

Maybe we should propose a PR for
https://github.com/jenkinsci/github-branch-source-plugin/blob/2cfdf198ad7f48e888dbc221d2a55004c30e758e/src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties#L16

@laeubi
Copy link

laeubi commented Jan 17, 2024

Maybe we should propose a PR for

That would be awesome but at the moment im not that deep in Jenkins plugin development to take action here.

@uhafner uhafner merged commit f7a00f8 into main Feb 23, 2024
20 of 22 checks passed
@uhafner uhafner deleted the stage-result branch February 23, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants