Add Pylint icons

[JeanChristopheMorinPerso]

Simply adding Pylint icons.

Changes in the supported formats file were generated by ToolsLister, as it should. It took me some time to figure out how to run it. Should we document how to run it?

[codecov]

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     81.05%   81.05%           
  Complexity     1396     1396           
=========================================
  Files           221      221           
  Lines          4682     4682           
  Branches        381      381           
=========================================
  Hits           3795     3795           
  Misses          757      757           
  Partials        130      130

Impacted Files	Coverage Δ	Complexity Δ
...a/io/jenkins/plugins/analysis/warnings/PyLint.java	93.1% <ø> (ø)	2 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beffe3d...b59572b. Read the comment docs.

[uhafner]

Thanks! What is the license for the icons? Maybe we can add it to the License.txt file.

[uhafner]

Where would be a good place to document the ToolsLister? I added a reference in the first line of the generated report, seems that this is not sufficient?

[JeanChristopheMorinPerso]

@uhafner Pylint is licensed under GNU General Public License v2.0 (https://github.com/PyCQA/pylint/blob/master/COPYING). The logo can be found at https://github.com/PyCQA/pylint/blob/master/doc/logo.png in the Pylint repo.

As for the ToolsLister, I can tell you that for me it wasn't obvious where that tool was in the first place, and then I had difficulties to understand why it wasn't executed with the tests (after I found that it was in the tests folder). Could it potentially be a maven goal or something just so we don't have to modify the pom.xml file to include the file in the test run ? (I'm far from a Java developer, so maybe it's not possible). For me, the end goal would be to make it even more easy for people that wants to contribute and that doesn't know the Java development stack that well (like me for example). What do you think?

[uhafner]

Hmm, I think we can't include something that is under GPL. IANAL but as far as I understand the license it is viral, i.e. I need to publish under GPL as well, I'm not sure how this is still valid by using the icon only.

[douardda]

Hi, I am the author of this icon. It's a quick'n dirty small icon I made (and I am in no way a designer of any kind, obviously) a while ago when I was at Logilab (my former employer and creator of pylint).

Not sure what I can do about this, but I'll see if the logo can be relicensed.

[uhafner]

IANAL but if you are the author of the icon I think we can add a copyright from you into the license.txt file. But if you could check with Logilab it would be more save...

[douardda]

well, the project is now managed by the community, so I think a PR on pylint's project should be ok. But I'll catch Logilab as well.

[uhafner]

Ah, then it might be sufficient to ask in the project...

[JeanChristopheMorinPerso]

Thanks @douardda for jumping in. Earlier, I tried to contact the PyCQA (Python Code Quality Authority) mailing list (see https://mail.python.org/pipermail/code-quality/2019-February/001097.html) but got no answer. I guess I should have asked straight in the GitHub repo...

[JeanChristopheMorinPerso]

@uhafner Good news is that the icon was re-licensed and the license change has been merged in pylint master. I guess we can proceed at adding the license in this repo.

Thanks @douardda :)