Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve several possible infinite hangings because of wait() #44

Merged
merged 3 commits into from
Jun 5, 2020

Conversation

Elisedlund-ericsson
Copy link
Contributor

Basically solving the similar hanging issues as https://github.com/jenkinsci/trilead-ssh2/pull/6/files

@kuisathaverat
Copy link
Contributor

kuisathaverat commented Jun 3, 2020

@Elisedlund-ericsson
Copy link
Contributor Author

Could you set it as a configurable property or use the same defined here?

https://github.com/kuisathaverat/trilead-ssh2/blob/2ce299400ebf2aab29a4572793bb04321cda8145/src/com/trilead/ssh2/auth/AuthenticationManager.java#L31
Thanks for input :)
added support for -DChannelManager.timeout=123456
Notice that its using a new property and not reusing -DAuthenticationManager.timeout
I felt that it would be strange to use a property named after another class.

@kuisathaverat kuisathaverat merged commit abcbee1 into jenkinsci:master Jun 5, 2020
@Elisedlund-ericsson
Copy link
Contributor Author

Nice, thanks :)
When can we expect a official release?
I would like to avoid depending on a internally released Trilead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants