Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on Jenkins 2.411 #233

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix tests on Jenkins 2.411 #233

merged 1 commit into from
Jun 20, 2023

Conversation

timja
Copy link
Member

@timja timja commented Jun 20, 2023

see jenkinsci/jenkins#8087 (comment)

Testing done

I ran the test that we were notified that was failing.
The above PR adds icon support to buttons which adds some new lines to the label in htmlunit.

It could be refactored to use j.submit(form) but I've just done the smallest fix here.

Submitter checklist

Preview Give feedback

@timja timja requested a review from a team as a code owner June 20, 2023 08:11
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil added the test label Jun 20, 2023
@basil basil merged commit 1bccbdc into jenkinsci:master Jun 20, 2023
@timja timja deleted the fix-pct branch June 21, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants