Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify node replacement code #82

Merged
merged 1 commit into from
Jun 2, 2019
Merged

Conversation

basil
Copy link
Member

@basil basil commented Apr 30, 2019

Downstream of #83. As @jglick observed in jenkinsci/workflow-durable-task-step-plugin#104, the existing code looks wrong. It could all be replaced by simply

jenkins.addNode(slave);

since that method already replaces any existing node of the same name, without firing the deleted event.

The existing node replacement code looks wrong. It could be simplified
to a single call to "jenkins.addNode(slave)", since that method already
replaces any existing node of the same name.
@basil basil force-pushed the nodeReplacement branch from 00845c6 to 3d173b6 Compare June 2, 2019 22:56
@basil basil merged commit 26793c0 into jenkinsci:master Jun 2, 2019
@basil basil deleted the nodeReplacement branch June 2, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant