Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-55787] Switch labels from entry to checkbox #119

Closed
wants to merge 3 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 12, 2019

https://issues.jenkins-ci.org/browse/JENKINS-55787

Basically checkboxes should have labels, splitting the labels away from their checkboxes is poor UX, poor accessibility. This change brings the layout more inline with how normal settings UIs lay out checkboxes.

This supersedes #117

@kuisathaverat
Copy link
Contributor

Could you please attach a screen capture of how to it is showing it before and after in relation with the rest of fields? I think it breaks the form view.

@jsoref
Copy link
Contributor Author

jsoref commented Feb 14, 2019

Today:
image
With this patch:
image

Going forward as part of jenkinsci/jenkins#3895:
image

@kuisathaverat
Copy link
Contributor

it without jenkinsci/jenkins#3895 it looks weird, but I like it too much with the whole solution. The only NIT is the help button. So I will monitor the 3895 and as soon it was merged this will be merged

@jsoref
Copy link
Contributor Author

jsoref commented Feb 18, 2019

@kuisathaverat : btw, do you have any particular input on the help button? -- See jenkinsci/jenkins#3895 (comment)

@kuisathaverat
Copy link
Contributor

I saw that jenkinsci/jenkins#3895 is closed so I guess this one has to be closed too, isn't it?

@jsoref
Copy link
Contributor Author

jsoref commented Mar 17, 2020

I still intend to get it done eventually. I might even try to poke the UX SIG this week.

@kuisathaverat
Copy link
Contributor

cool, I'll keep it open

@kuisathaverat
Copy link
Contributor

Without the change
Screenshot 2021-05-01 at 12 30 46

With the change
Screenshot 2021-05-01 at 12 33 07

@jsoref
The changes you made on the core are so good that the PR is not needed anymore, thank you, if you are OK we can close the PR.

@jsoref jsoref closed this May 2, 2021
@jsoref jsoref deleted the JENKINS-55787 branch May 2, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants