-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-55787] Switch labels from entry to checkbox #119
Conversation
Could you please attach a screen capture of how to it is showing it before and after in relation with the rest of fields? I think it breaks the form view. |
Going forward as part of jenkinsci/jenkins#3895: |
it without jenkinsci/jenkins#3895 it looks weird, but I like it too much with the whole solution. The only NIT is the help button. So I will monitor the 3895 and as soon it was merged this will be merged |
@kuisathaverat : btw, do you have any particular input on the help button? -- See jenkinsci/jenkins#3895 (comment) |
I saw that jenkinsci/jenkins#3895 is closed so I guess this one has to be closed too, isn't it? |
I still intend to get it done eventually. I might even try to poke the UX SIG this week. |
cool, I'll keep it open |
@jsoref |
https://issues.jenkins-ci.org/browse/JENKINS-55787
Basically checkboxes should have labels, splitting the labels away from their checkboxes is poor UX, poor accessibility. This change brings the layout more inline with how normal settings UIs lay out checkboxes.
This supersedes #117