Configure Dependabot to ignore Caffeine 3.x due to Java 11 requirement #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
car-roll
approved these changes
Feb 24, 2021
|
Caffeine 2.x will continue to be supported on Java 8. That likely won't include new features, but will have bug fixes and similar improvements. The major bump was not meant to imply that we are going to abandon users, but was needed to support those who want us to use VarHandles (Java 9+). The major version provided the ability to do minor clean up and other fixes that can't be done incrementally in a semver's minor/patch cycle. We'll continue making releases for 2.x as issues are found, though with a tendency to not backport major new functionality unless requested, discussed, and semver compatible. |
|
@ben-manes Ok, thanks for letting us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #331 and https://github.com/ben-manes/caffeine/releases/tag/v3.0.0.
We cannot update
caffeineto 3.0.0 until a version of Jenkins that requires Java 11 is released and we are ready to update the minimum supported Jenkins version here inscript-securityto that version.Maybe it would make sense to try to replace the
caffeinedependency with a small API on top ofConcurrentHashMapor similar if we are not going to be able to update the dependency for a long time. Personally, I am not as concerned about the performance of the caching layer (at least as long as the performance is not terrible) as I am about its correctness, so from my PoV the main benefit of switching tocaffeinein #160 was that we could avoid the concurrency-related issues we were occasionally seeing with the Guava cache (admittedly, Jenkins is using a very old version of Guava).Closes #331.