remove dead yui code #276
Merged
remove dead yui code #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since longer time the repeatable delete is no longer a button created by yui but directly converted by Jenkins core to button element with class jenkins-button. So the call to YAHOO.widget.Button.getButton(e.id) will always return undefined. The layoutUpdateCallback will make sure that when the delete button is clicked the traitSectionRule is called.
jglick
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since longer time the repeatable delete is no longer a button created by yui but directly rendered by Jenkins core as button element So the call to YAHOO.widget.Button.getButton(e.id) will always return undefined. The
layoutUpdateCallbackwill make sure that when the delete button is clicked thetraitSectionRuleis called.Testing done
Manual testing
Submitter checklist