Small refactoring #32
Conversation
- bump plugin parent pom - also add escape-by-default into Jelly files - add final to a static variable
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Isn't it a feature that users can log in to Jenkins with their display name? This seems to disable that. |
|
As mentioned @daniel-beck we could break a feature that is potentially used : the LDAP search using the FullName (against cn ?). The other changes are still interesting, but nothing really important. |
|
@reviewbybees done |
| @@ -117,7 +117,7 @@ | |||
| * See http://msdn.microsoft.com/en-us/library/aa746475(VS.85).aspx for the syntax by example. | |||
| * WANTED: The specification of the syntax. | |||
| */ | |||
| public static String GROUP_SEARCH = System.getProperty(LDAPSecurityRealm.class.getName()+".groupSearch", | |||
| public static final String GROUP_SEARCH = System.getProperty(LDAPSecurityRealm.class.getName()+".groupSearch", | |||
There was a problem hiding this comment.
After this change it won't be possible to change them dynamically in System Groovy Scripts
|
FindBugs will likely grumble, we will fix it in the master branch |
Main issue was to retrieve the User by username potentially.
@reviewbybees @jtnord (especially for the getById without creation)