adding an option to ignore specific projects on scm poll. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
| @@ -312,7 +327,8 @@ public RepoScm(final String manifestRepositoryUrl, | |||
| final boolean resetFirst, | |||
| final boolean quiet, | |||
| final boolean trace, | |||
| final boolean showAllChanges) { | |||
| final boolean showAllChanges, | |||
| final String ignoreProjects) { | |||
There was a problem hiding this comment.
This constructor is deprecated and is only kept for backwards compat reasons, so do not add any changes to it.
|
@rsandell i had commit-ammended code review comments fixes. please review |
|
@rsandell can you please review and merge the changes. |
| this.ignoreProjects = Collections.<String>emptySet(); | ||
| return; | ||
| } | ||
| this.ignoreProjects = new LinkedHashSet<String>(Arrays.asList(ignoreProjects.split(" "))); |
There was a problem hiding this comment.
Should be ignoreProjects.split("\\s+") to split on all white space characters (so that you can have one project per line for example)
|
Sorry for the delay, I've been on business trips with very little time to look at any code :) |
|
@rsandell i updated the pullrequest .. please review. |
rsandell
added a commit
that referenced
this pull request
Feb 22, 2016
adding an option to ignore specific projects on scm poll.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an ability to "ignore" changes on specific project while "polling" for changes from the scm.
This is useful for example when the build process itself commits a change to specific repository, to avoid re-trigger the build.