Restore SSLContextRule tests
#573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating this repository to use Java 11 in #495, I took a shortcut and skipped the
SSLContextRuletests rather than fixing them. This PR undoes that change, restoring the tests and getting them to work on Java 11.They had started failing with "Certificate chain is not valid" errors. Looking into this further I found that the first argument to
X509v3CertificateBuilder, which is supposed to be the signer/issuer, was actually a subject. This made no sense except for self-signed certificates, but apparently worked on older versions of Java. To fix this I changed the test logic to plumb through the root certificate in any certificate chains. With this object plumbed through, we could call itsgetSubjectX500Principal()method as recommended in the Bouncy Castle documentation to get the correct first argument to pass when building the X509 certificate. And with that the tests pass again on Java 11.