Refresh plugin for June 2023 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Jun 29, 2023
| @@ -2,6 +2,6 @@ | |||
| <extension> | |||
| <groupId>io.jenkins.tools.incrementals</groupId> | |||
| <artifactId>git-changelist-maven-extension</artifactId> | |||
| <version>1.4</version> | |||
| <version>1.6</version> | |||
There was a problem hiding this comment.
Latest at the time of this writing.
Comment on lines
+2
to
+5
| buildPlugin(useContainerAgent: true, configurations: [ | ||
| [platform: 'linux', jdk: 17], | ||
| [platform: 'windows', jdk: 11], | ||
| ]) |
There was a problem hiding this comment.
Following the latest archetype.
Comment on lines
+35
to
+40
| <properties> | ||
| <revision>1.25</revision> | ||
| <changelist>-SNAPSHOT</changelist> | ||
| <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> | ||
| <jenkins.version>2.361.4</jenkins.version> | ||
| </properties> |
There was a problem hiding this comment.
Fixing indentation and making this consistent with the archetype.
|
|
||
| <artifactId>publish-over-ssh</artifactId> | ||
| <packaging>hpi</packaging> | ||
| <name>Publish Over SSH</name> | ||
| <version>${revision}${changelist}</version> | ||
| <description>Send build artifacts over SSH</description> | ||
| <url>https://github.com/jenkinsci/publish-over-ssh-plugin</url> | ||
| <url>https://github.com/jenkinsci/${project.artifactId}-plugin</url> |
There was a problem hiding this comment.
Consistent with the archetype.
|
|
||
| <licenses> | ||
| <license> | ||
| <name>The MIT license</name> | ||
| <url>https://opensource.org/license/mit/</url> |
There was a problem hiding this comment.
Consistent with the archetype.
| <artifactId>bom-2.289.x</artifactId> | ||
| <version>1500.ve4d05cd32975</version> | ||
| <artifactId>bom-2.361.x</artifactId> | ||
| <version>2102.v854b_fec19c92</version> |
There was a problem hiding this comment.
Latest release of the 2.361.x BOM line.
Comment on lines
+92
to
+95
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>jackson2-api</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Using a library plugin to implement dynamic linking as recommended when such library plugins exist.
Comment on lines
+27
to
+29
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.ArgumentMatchers.anyString; | ||
| import static org.mockito.ArgumentMatchers.eq; |
There was a problem hiding this comment.
Adapting to recent versions of Mockito.
Closed
gmcdonald
added
the
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.