Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer project-inheritance dependency (19.08.02 instead of 1.5.3) #153

Merged
merged 1 commit into from
May 13, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented May 10, 2021

As reported by @jtnord, otherwise tests fail with -Djenkins.version=2.278 due to

java.util.concurrent.ExecutionException: java.lang.NoSuchMethodError: hudson.model.Queue$WaitingItem.getFuture()Ljava/util/concurrent/Future;
	at hudson.remoting.AsyncFutureImpl.get(AsyncFutureImpl.java:81)
	at org.jvnet.hudson.test.JenkinsRule.assertBuildStatus(JenkinsRule.java:1332)
	at org.jvnet.hudson.test.JenkinsRule.assertBuildStatusSuccess(JenkinsRule.java:1361)
	at org.jvnet.hudson.test.JenkinsRule.buildAndAssertSuccess(JenkinsRule.java:1373)
	at hudson.plugins.promoted_builds.conditions.inheritance.DownstreamPassConditionInheritanceTest.shouldEvaluateUpstreamRecursively(DownstreamPassConditionInheritanceTest.java:66)
	at …
Caused by: java.lang.NoSuchMethodError: hudson.model.Queue$WaitingItem.getFuture()Ljava/util/concurrent/Future;
	at hudson.plugins.project_inheritance.projects.InheritanceProject.scheduleBuild2(InheritanceProject.java:1794)
	at hudson.model.AbstractProject.scheduleBuild2(AbstractProject.java:804)
	at hudson.model.AbstractProject.scheduleBuild(AbstractProject.java:792)
	at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:277)
	at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:713)
	at hudson.model.Build$BuildExecution.cleanUp(Build.java:192)
	at hudson.model.Run.execute(Run.java:1954)
	at hudson.plugins.project_inheritance.projects.InheritanceBuild.run(InheritanceBuild.java:139)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)

This dep was introduced in #75 but the plugin is not in @jenkinsci and shows a warning in the UC for almost a year due to an unresolved vulnerability. There has been activity since then i-m-c/jenkins-inheritance-plugin@ff1effd...master but apparently not to fix the vulnerability. Suggest removing the integration here; the dependency would better be inverted anyway. @J-cztery @HedAurabesh

Root cause unclear, but perhaps due to jenkinsci/jenkins#5232 and/or jenkinsci/jenkins#5210 with jenkinsci/bridge-method-injector@bridge-method-injector-parent-1.13...bridge-method-injector-parent-1.18 @daniel-beck?

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections

@oleg-nenashev oleg-nenashev changed the title Use newer project-inheritance dep Use newer project-inheritance dependency (19.08.02 instead of 1.5.3) May 10, 2021
@jglick
Copy link
Member Author

jglick commented May 10, 2021

Oddly enough, git bisect says that it was neither of those PRs that was responsible—rather it was jenkinsci/jenkins#5208. Trying to figure out why.

@jglick
Copy link
Member Author

jglick commented May 10, 2021

Specifically jenkinsci/lib-annotation-indexer#10 seems to have broken the bridge-method-injector, somehow.

@jglick
Copy link
Member Author

jglick commented May 10, 2021

jenkinsci/bridge-method-injector#25 should fix it. Unfortunately I have no permissions to that repository.

@jglick
Copy link
Member Author

jglick commented May 13, 2021

Root cause has been addressed, but I see no reason not to merge this anyway so we are not using a very old dep.

@jglick jglick merged commit 97ee1d6 into jenkinsci:master May 13, 2021
@jglick jglick deleted the bump-project-inheritance branch May 13, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants