Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-42816] use agent terminology and fix help for label. #152

Merged
merged 2 commits into from
May 20, 2021

Conversation

aHenryJard
Copy link

@aHenryJard aHenryJard commented May 3, 2021

See JENKINS-42816.

  • use agent terminology
  • the help message for label was not displayed, added the missing field value to have it displayed.

I have run tests locally, it seems ok

Screenshot of the help message (using mvn hpi:run):
agent terminology

Your checklist for this pull request

  • Pull request title represents the changelog entry which will be used in Release Notes. JIRA issue is a part of the title (see existing PRs as examples)
  • Please describe what you did. Short summary for reviewers. If the change involves WebUI, add screenshots
  • Link to relevant Jenkins JIRA issues or pull requests
  • Test automation, if relevant. We expect autotests for all new features or complex bugfixes
  • Documentation if relevant (new features). We want to use Documentation-as-Code, just put docs to README or to new Doc files
  • Javadoc for new APIs. Any public/protected method is considered as API unless annotated by Restricted (docs)

CC

@mention

@aHenryJard aHenryJard changed the title [JENKINS-42816] agent terminology. [JENKINS-42816] use agent terminology and fix help for labels. May 3, 2021
@aHenryJard aHenryJard changed the title [JENKINS-42816] use agent terminology and fix help for labels. [JENKINS-42816] use agent terminology and fix help for label. May 3, 2021
@Vlatombe
Copy link
Member

@jtnord or @jglick would you mind merging/releasing this change?

@jglick jglick merged commit 7788115 into jenkinsci:master May 20, 2021
@jglick
Copy link
Member

jglick commented May 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

6 participants