Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#635][#683] Fixing startup problems in certain Jenkins installations #685

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

Dohbedoh
Copy link

Fixes #683

Changes proposed

  • Aynchronously register collectors to prevent blocking Jenkins startup.

Checklist

  • Includes tests covering the new functionality?
  • Ready for review
  • Follows CONTRIBUTING rules

Notify

@Waschndolos

.schedule(
new SafeTimerTask() {
@Override
public void doRun() throws Exception {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning

Potential CSRF vulnerability: If #doRun connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
.schedule(
new SafeTimerTask() {
@Override
public void doRun() throws Exception {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check Warning

Potential missing permission check in #doRun
@Waschndolos Waschndolos changed the title [#635][#683] Launch collector registration asynchronously [#635][#683] Fixing startup problems in certain Jenkins installations Jul 26, 2024
@Waschndolos Waschndolos merged commit b59179a into jenkinsci:master Jul 26, 2024
28 checks passed
@Dohbedoh Dohbedoh deleted the bugfix/635 branch July 26, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus Plugin Update from 773.v3b_62d8178eec to 778.ve1c932a_ff24f prevents Jenkins from startup
2 participants