-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update baseline, POM, BOM #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not approve this due to the use bom version here which will cause uneeded work (or the work would be needed but there is no comment as to why something newer needs to be picked up)/
useContainerAgent: true, | ||
configurations: [ | ||
[platform: 'linux', jdk: 17], | ||
[platform: 'windows', jdk: 11], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as mentioned before - this is not something I believe is good. it saves some compute $$$ but does not save any wall clock time on the build and makes windows related issues more of "is this windows or jdk" in a non obvious way (esp when the tests pass locally due to some timing thing..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Jenkinsfile
is currently the stock recommendation. If you wish to suggest a different stock Jenkinsfile
, run it by ci.jenkins.io admins and propose that change in archetypes
.
Co-authored-by: James Nord <[email protected]>
Supersedes #38, #39, & #42.