Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routine updates for JDK11 build compatibility #27

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Nov 4, 2021

  • Update parent POM
  • Use BOM
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

* Update parent POM
* Use BOM
Copy link

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer jenkins 2.249.x LTS if possible.

Copy link

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer jenkins 2.249.x LTS if possible.

@Vlatombe Vlatombe requested a review from bitwiseman December 7, 2021 10:14
@batmat batmat requested review from Wadeck and daniel-beck January 7, 2022 10:20
@mikecirioli
Copy link

gentle nudge @Wadeck && @daniel-beck

@Wadeck
Copy link

Wadeck commented Jan 11, 2022

@mikecirioli sorry, no time at the moment, preparing next security release. Perhaps after Jan 12 we will have more time.

Is it blocking you?

@mikecirioli
Copy link

its not urgently blocking @Wadeck - if you can find a few minutes after jan 12th gaia team would appreciate it!

@mikecirioli
Copy link

@Wadeck gentle nudge 😉

@daniel-beck daniel-beck added the chore For changelog: A maintenance chore with no functional changes label Jan 24, 2022
<dependencies>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>credentials</artifactId>
<version>2.2.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency is increased to 2.6.1 through the BOM.

@daniel-beck daniel-beck merged commit afec4d4 into jenkinsci:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For changelog: A maintenance chore with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants