[JENKINS-72611] Do not update credentials ID in BaseTest

jenkinsci · Mar 4, 2024 · d01156f · d01156f
1 parent 1ef1c60
commit d01156f
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/test/java/org/jenkinsci/plugins/plaincredentials/BaseTest.java b/src/test/java/org/jenkinsci/plugins/plaincredentials/BaseTest.java
@@ -34,7 +34,6 @@
 
 public class BaseTest {
 
-    private static final String UPDATED_CRED_ID = "Custom-ID-Updated";
     private static final String CRED_ID = "Custom-ID";
 
     @Rule
@@ -50,7 +49,7 @@ public void setup(){
     @Test
     public void secretTextBaseTest() throws IOException {
         StringCredentialsImpl credential = new StringCredentialsImpl(CredentialsScope.GLOBAL, CRED_ID, "Test Secret Text", Secret.fromString("password"));
-        StringCredentialsImpl updatedCredential = new StringCredentialsImpl(credential.getScope(), UPDATED_CRED_ID, credential.getDescription(), credential.getSecret()); 
+        StringCredentialsImpl updatedCredential = new StringCredentialsImpl(credential.getScope(), CRED_ID, credential.getDescription(), credential.getSecret());
         testCreateUpdateDelete(credential, updatedCredential);
     }
 
@@ -75,7 +74,7 @@ private void secretFileTest(boolean useDeprecatedConstructor) throws IOException
             credential = new FileCredentialsImpl(CredentialsScope.GLOBAL, CRED_ID, "Test Secret file", fileItem, "keys.txt", SecretBytes.fromBytes(fileItem.get()));
         }
 
-        FileCredentialsImpl updatedCredential = new FileCredentialsImpl(credential.getScope(), UPDATED_CRED_ID, credential.getDescription(), fileItem, credential.getFileName(), credential.getSecretBytes());
+        FileCredentialsImpl updatedCredential = new FileCredentialsImpl(credential.getScope(), CRED_ID, credential.getDescription(), fileItem, credential.getFileName(), credential.getSecretBytes());
         testCreateUpdateDelete(credential, updatedCredential);
     }
 
@@ -108,7 +107,7 @@ private <T extends BaseStandardCredentials> void testCreateUpdateDelete(T creden
         assertThat(credentials.size(), is(1));
         cred = credentials.get(0);
         assertThat(cred, instanceOf(credential.getClass()));
-        assertThat(cred.getId(), is(UPDATED_CRED_ID));
+        assertThat(cred.getId(), is(CRED_ID));
 
         // Delete credential
         store.removeCredentials(Domain.global(), cred);