Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JSR-305 annotations #103

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

offa
Copy link
Contributor

@offa offa commented Jun 17, 2021

Replaces the JSR-305 @Nonnull / @CheckForNull annotations (jenkinsci/jenkins#4604).

ℹ️ The spotbugs annotations are marked as deprecated, but updating to a more recent Jenkins version should fix that (eg. #100).

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@rsandell rsandell added the chore label Aug 27, 2021
@rsandell rsandell merged commit 6ee7119 into jenkinsci:master Aug 27, 2021
@offa offa deleted the remove_jsr305 branch August 27, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants