Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Adding rocketchat-notifier plugin #423

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hypery2k
Copy link

No description provided.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wiki claims that the latest version is 0.4.4, and currently sources do not show Pipeline compatibility. Perhaps there is some fork of this plugin floating out there and not on the standard update center?

COMPATIBILITY.md Outdated
@@ -47,6 +47,7 @@ Newly filed issues should bear the label `pipeline` for ease of tracking.
- [X] `HipChatNotifier` (`hipchat`): supported as of 1.0.0
- [ ] `IronMQNotifier` (`ironmq-notifier`): [JENKINS-35505](https://issues.jenkins-ci.org/browse/JENKINS-35505)
- [X] `LogParserPublisher` (`log-parser`): supported as of 2.0
- [X] `RocketChatNotifier` (`rocketchat-notifier`): supported as of 2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin name is rocketchatnotifier AFAICT.

@hypery2k
Copy link
Author

COMPATIBILITY.md Outdated
@@ -47,6 +47,7 @@ Newly filed issues should bear the label `pipeline` for ease of tracking.
- [X] `HipChatNotifier` (`hipchat`): supported as of 1.0.0
- [ ] `IronMQNotifier` (`ironmq-notifier`): [JENKINS-35505](https://issues.jenkins-ci.org/browse/JENKINS-35505)
- [X] `LogParserPublisher` (`log-parser`): supported as of 2.0
- [X] `RocketChatNotifier` (`rocketchatnotifier`): supported as of 2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this 2.0? The wiki says the latest is 0.5.0. And the step exists from at least 0.2.1.

And how is this RocketChatNotifier? This is a custom step, which has its own section.

@hypery2k
Copy link
Author

@jglick Thanks for the hint. I've updated the version number

@@ -47,6 +47,7 @@ Newly filed issues should bear the label `pipeline` for ease of tracking.
- [X] `HipChatNotifier` (`hipchat`): supported as of 1.0.0
- [ ] `IronMQNotifier` (`ironmq-notifier`): [JENKINS-35505](https://issues.jenkins-ci.org/browse/JENKINS-35505)
- [X] `LogParserPublisher` (`log-parser`): supported as of 2.0
- [X] `RocketChatNotifier` (`rocketchatnotifier`): supported as of 0.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still incorrect as previously noted. This is a custom step (rocketSend). The original RocketChatNotifier post-build action is not compatible with Pipeline AFAICT.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants