Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FlowNodeWrapper#getNodeType so it can return NodeType.STEP #354

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

stuartrowe
Copy link
Contributor

Fixes #352.

Changed the order in which the NodeType criteria are checked. Evaluating node instanceof AtomNode before checking PipelinelineNodeUtil.isStage(node) avoids the situation where an AtomNode is considered a NodeType.STAGE just because it has an associated LabelAction.

Testing done

It's not clear to me what impact this fix actually has, but it was clearly wrong before.

Submitter checklist

Preview Give feedback

@stuartrowe stuartrowe requested a review from a team as a code owner March 5, 2024 05:25
@timja timja added the bug Something isn't working label Mar 6, 2024
@timja timja merged commit 1361efa into jenkinsci:main Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlowNodeWrapper#getNodeType returns NodeType.STAGE when a step node has a LabelAction
2 participants