Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect step result when referencing an ErrorAction #353

Closed
wants to merge 1 commit into from

Conversation

stuartrowe
Copy link
Contributor

Fix for #350.

The NodeRunStatus constructor was reading the result from the associated ErrorAction but then not directly using it to set NodeRunStatus#result. Instead this.result was always being set to BlueRunResult.FAILURE unless the local result was equal to Result.ABORTED.

I implemented a new method for translating Result to BlueRunResult and used that to set NodeRunStatus#result instead.

Before
Screenshot 2024-03-04 at 8 55 12 PM

After
Screenshot 2024-03-04 at 8 57 40 PM

Testing done

Submitter checklist

Preview Give feedback

@stuartrowe stuartrowe marked this pull request as ready for review March 5, 2024 05:20
@stuartrowe stuartrowe requested a review from a team as a code owner March 5, 2024 05:20
@stuartrowe
Copy link
Contributor Author

Bad source branch name.

@stuartrowe stuartrowe closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant