Fix incorrect step result when referencing an ErrorAction #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #350.
The NodeRunStatus constructor was reading the result from the associated
ErrorAction
but then not directly using it to setNodeRunStatus#result
. Insteadthis.result
was always being set toBlueRunResult.FAILURE
unless the localresult
was equal toResult.ABORTED
.I implemented a new method for translating
Result
toBlueRunResult
and used that to setNodeRunStatus#result
instead.Before
After
Testing done
Submitter checklist