Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract logs retriever API #311

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

cyrille-leclerc
Copy link
Contributor

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@cyrille-leclerc
Copy link
Contributor Author

cyrille-leclerc commented Feb 6, 2022

@kuisathaverat please look at the LogStorageRetriever API

<f:validateButton title="${%Validate configuration}" progress="Validating..." method="validate/"
with="elasticsearchUrl,elasticsearchCredentialsId,indexPattern"/>
</f:section>
</f:advanced>
</f:advanced>ElasticsearchLogStorageRetriever
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is a typo

Suggested change
</f:advanced>ElasticsearchLogStorageRetriever
</f:advanced>

Copy link
Contributor

@kuisathaverat kuisathaverat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than a typo everything LGTM

@cyrille-leclerc cyrille-leclerc merged commit ed1594d into send-build-logs-to-otel Feb 7, 2022
@cyrille-leclerc cyrille-leclerc deleted the extract-logs-retriever-api branch February 7, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants