Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed slaves labels/individual nodes list description display null #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mamh2021
Copy link

in Configuration Matrix add axis/ add slaves:
Labels
Labels_s2 (null)
Labels_windows (this is windows)
master_Labels (master_Labels Description)

Individual nodes
master (null)
s1 (null)
s2 (null)

after fix:
Labels
Labels_s2 (s2)
Labels_windows (this is windows: s2)
master_Labels (master_Labels Description: Jenkins, s1)

Individual nodes
master (the master Jenkins node)
s1 (Description s1)
s2 (Description s2)

Signed-off-by: Mamh-Linux [email protected]

@oleg-nenashev
Copy link
Member

What is the purpose of comments in Chinese? If it is an example of a rendered string, it is still confusing

in Configuration Matrix add axis/ add slaves:
Labels
    Labels_s2 (null)
    Labels_windows (this is windows)
    master_Labels (master_Labels Description)

Individual nodes
    master (null)
    s1 (null)
    s2 (null)

after fix:
Labels
    Labels_s2 (s2)
    Labels_windows (this is windows: s2)
    master_Labels (master_Labels Description: Jenkins, s1)

Individual nodes
    master (the master Jenkins node)
    s1 (Description s1)
    s2 (Description s2)

Signed-off-by: Mamh-Linux <[email protected]>
@mamh2021 mamh2021 force-pushed the fix-description-null branch from 735e45d to 1b0cea8 Compare July 10, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants