Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(MatrixTestResult): Increase column width for duration #178

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

pmhahn
Copy link
Contributor

@pmhahn pmhahn commented Oct 11, 2023

4em is too narrow for texts like 6 hr 17 min to fit into: It is shown on two lines as:

6 hr 17
min

The German translation is even worse, which spans 4 lines:

6
Stunden
17
Minuten

which make the table take up too much space.

Testing done

# jar xf matrix-project.jar hudson/tasks/test/MatrixTestResult/index.jelly
# vi  hudson/tasks/test/MatrixTestResult/index.jelly
# jar uf matrix-project.jar hudson/tasks/test/MatrixTestResult/index.jelly
# restart jenkins

jenkins-old
jenkins-new

Submitter checklist

Preview Give feedback

`4em` is too narrow for texts like `6 hr 17 min` to fit into: It is shown on two lines as:
> 6 hr 17
> min

The German translation is even worse, which spans 4 lines:
> 6
> Stunden
> 17
> Minuten

which make the table to take up too much space.
@rsandell rsandell added the ui label Oct 16, 2023
@rsandell rsandell merged commit 7ebe657 into jenkinsci:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants