Adjust/enhance some tests #113
Conversation
Print out more information on failure Mention that some tests need to run with installed agent Add a few more tests Some classes are not available when running tests on Windows
| assertNotNull("No file record for file=" + tempFile + " found", findFileRecord(tempFile)); | ||
|
|
||
| assertThat("Did not have the expected type of 'marker' object: " + obj, |
There was a problem hiding this comment.
This assertion fails when I run the test on my Red Hat Enterprise Linux 8 computer with Eclipse Adoptium Java 11.0.16.1 and Apache Maven 3.8.6 using the command line:
$ mvn -version
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /home/mwaite/tools/apache-maven-3.8.6
Java version: 11.0.16.1, vendor: Eclipse Adoptium, runtime: /home/mwaite/tools/jdk-11.0.16.1+1
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.18.0-372.19.1.el8_6.x86_64", arch: "amd64", family: "unix"
$ mvn clean verify
[ERROR] Failures:
[ERROR] FileDemo.openCloseFileLines:262 Did not have the expected type of 'marker' object: sun.net.www.protocol.jar.URLJarFile@7b69c6ba
Expected: an instance of java.nio.channels.SeekableByteChannel
but: <sun.net.www.protocol.jar.URLJarFile@7b69c6ba> is a sun.net.www.protocol.jar.URLJarFile
[INFO]
[ERROR] Tests run: 14, Failures: 1, Errors: 0, Skipped: 0
The same failure is seen with JDK 11.0.16 that is available with RHEL 8 as an RPM package.
The same command line, operating system, and Java version run the test successfully from the master branch.
The failure is not seen with JDK 17.0.4.1 with this pull request.
There was a problem hiding this comment.
This is a very strange flakiness that is likely not introduced by my changes.
It works at times, but fails with this sometimes. Seems to be some race condition with some jar-file loading in other threads or similar.
I can try to narrow it down a bit more.
There was a problem hiding this comment.
Seems to be a close() via a Finalizer done concurrently sometimes.
I now exclude closing of URLJarFile in the test to avoid this flakiness.
This seems to happen concurrently via finalizers and did lead to flaky tests
There was a problem hiding this comment.
I've confirmed that the machine that previously showed consistent failures did not show any failure with 10 runs of mvn clean verify. Also confirmed no failures with 10 runs on a second machine. Thanks very much!
Optional comment based on formatting. Whether or not that comment is applied, I plan to merge this after 24 hours unless others raise an objection.
src/test/java/org/kohsuke/file_leak_detector/instrumented/FileDemo.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Waite <[email protected]>
Print out more information on failure
Mention that some tests need to run with installed agent
Add a few more tests
Some classes are not available when running tests on Windows