-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong command line in "Attaching after JVM startup" #153
Comments
So you would like the documentation to be updated to read |
@basil Exactly. At least this worked for me. |
And you decided to file an issue for this rather than a pull request? |
Yes - I considered it dangerous to send pull request after having used this project for the first time and not having any detailed knowledge ;-). If you prefer it, I can create a pull request, but as I wrote before, I don't know whether the chapter "Usage" would also have to be changed. |
Yes, please submit a pull request. Don't worry about that other chapter... you've already demonstrated that your proposed improvement is a strict improvement over the status quo. |
…-with-dependencies.jar, added sample for permanent logging (#156)
Describe your use-case which is not covered by existing documentation.
The chapter Attaching after JVM startup uses this command:
java -jar path/to/file-leak-detector.jar 1500 threshold=200,strong
This does not work for me: "file-leak-detector-1-16.jar" does not define a Main class. And when declaring the class to invoke, there is an error about missing classes ("ags4j" stuff).
You have to use the file "file-leak-detector-1.16-jar-with-dependencies.jar"
Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.
No response
The text was updated successfully, but these errors were encountered: