Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing tests around subclasses #20

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

daniel-beck
Copy link
Member

I was so confused earlier today trying to mark something @Restricted, and apparently, this is the cause.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we merge @daniel-beck?

@timja timja added the tests label Dec 15, 2020
@daniel-beck
Copy link
Member Author

This PR adds failing tests, your CI setup is broken:

20:52:19  [INFO] -------------------------------------------------
20:52:19  [INFO] Build Summary:
20:52:19  [INFO]   Passed: 10, Failed: 2, Errors: 0, Skipped: 0
20:52:19  [INFO] -------------------------------------------------
20:52:19  [WARNING] The following builds failed:
20:52:19  [WARNING] *  extend-override/pom.xml
20:52:19  [WARNING] *  extend/pom.xml
20:52:19  [INFO] -------------------------------------------------
20:52:19  [WARNING] Ignoring that 2 builds failed.

@timja
Copy link
Member

timja commented Dec 15, 2020

ah k,

I thought that

access-modifier-checker/src/it/extend-override/invoker.properties

invoker.buildResult = failure

was telling it that it expected to fail and would be removed when fixing the issue

@timja
Copy link
Member

timja commented Dec 15, 2020

Issue is this: jenkins-infra/pipeline-library#139 (comment)

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the Invoker equivalent of @Ignore pending a fix for the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants