Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enhanced PV support in Kind 0.7.0 #685

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 15, 2020

kind.sh Outdated Show resolved Hide resolved
@jglick
Copy link
Member Author

jglick commented Jan 15, 2020

I think ContainerExecDecoratorTest.testCommandExecution may be failing…

@jglick
Copy link
Member Author

jglick commented Jan 15, 2020

assertTrue("Output should contain pid: " + r.output, PID_PATTERN.matcher(r.output).find());

@jglick
Copy link
Member Author

jglick commented Jan 15, 2020

From build 1:

java.lang.AssertionError: 
 Output should contain pid: Executing sh script inside container busybox of pod test-command-execution-m0rc2
 Executing command: "sh" "-c" "cd /tmp; echo [4] pid is \$\$ > test; cat /tmp/test" 
 exit
 
 	at org.junit.Assert.fail(Assert.java:88)
 	at org.junit.Assert.assertTrue(Assert.java:41)
 	at org.csanchez.jenkins.plugins.kubernetes.pipeline.ContainerExecDecoratorTest.testCommandExecution(ContainerExecDecoratorTest.java:164)

Looks like one of the threads failed but others worked? Maybe a flaky test? Test took 549s to fail, which suggests something was hanging. Also seems stuck here in build 2.

@jglick
Copy link
Member Author

jglick commented Jan 15, 2020

Now passes, though it seems unreasonable long:

​[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 533.232 s - in org.csanchez.jenkins.plugins.kubernetes.pipelie.ContainerExecDecoratorTest

Seems each of the test cases takes ~40s. Not a regression from master, though.

@jglick jglick requested a review from Vlatombe January 15, 2020 22:17
@jglick
Copy link
Member Author

jglick commented Jan 15, 2020

Most of that time seems to be spent in KubernetesTestUtil.deletePods.

@Vlatombe
Copy link
Member

Indeed, i've noticed this slowness for a while, not sure when it started to appear...

@Vlatombe Vlatombe added the test Tests label Jan 16, 2020
@Vlatombe Vlatombe merged commit 7b13ff7 into jenkinsci:master Jan 16, 2020
@jglick jglick deleted the kind-pvc branch January 16, 2020 13:08
This was referenced Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants