Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hashbang from examples #595

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Conversation

Vlatombe
Copy link
Member

Not needed anymore since #490

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to update these examples while I was here!

examples/kaniko-declarative.groovy Outdated Show resolved Hide resolved
examples/kaniko-gcr.groovy Outdated Show resolved Hide resolved
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.

@@ -10,8 +10,6 @@

podTemplate(yaml: """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again unrelated to this PR, but: I always recommend using single quotes (''' in this case) for strings in Pipeline script unless you really mean to interpolate Groovy variables.

@Vlatombe Vlatombe merged commit af24964 into jenkinsci:master Sep 12, 2019
@Vlatombe Vlatombe deleted the Vlatombe-patch-1 branch September 12, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants