[JENKINS-56121] Add option to (not) show raw yaml in console #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the raw yaml can add quite some noise to the console log, an option was added to disable it. Default is ShowRawYaml=true, so the default behavior does not change.
carlossg
requested changes
May 2, 2019
src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplate.java
Outdated
Show resolved
Hide resolved
|
I can't push to the PR, can you add this commit ? |
I did the change requested but why change boolean to Boolean? |
|
It's a tricky thing with Jenkins. On upgrade only the readResolve method is called, not the initializers. We need to set the value to true, so using a boolean we can see that if it is null it means we are upgrading and then set it to true. |
carlossg
approved these changes
May 9, 2019
Thanks for the explanation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-56121
Based on #451 @fredg02
Since the raw yaml can add quite some noise to the console log, an
option was added to disable it. Default is ShowRawYaml=true, so the
default behavior does not change.